fix: adapt type of valid minmax #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
renaudjester
approved these changes
Sep 13, 2024
uriii3
commented
Sep 13, 2024
Comment on lines
+452
to
+455
| if ( | ||
| "valid_min" in dataset[variable].attrs | ||
| and "valid_max" in dataset[variable].attrs | ||
| ): |
There was a problem hiding this comment.
better, no? @renaudjester
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Making sure the formats of the variables have the same accuracy (if float32, then float32, not float in general)
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Making sure the formats of the variables have the same accuracy (if float32, then float32, not float in general)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pull 127 we discovered that the values of
valid_minandvalid_maxdidn't have the same format as the variable, which isn't consistent with the CF convention.I've created this changes to make sure that the types of the values are correct.